search

blackberry / BB10-Webworks-Packager

The BB10 WebWorks Packager bundles the App content with the BB10 WebWorks Framework to create a BAR to run on the BB10 Device (or simulator)
27 stars 18 forks source link

Updating logic in packager to fix broken localization on Windows OS. #254

Closed ejzn closed 11 years ago

ejzn commented 11 years ago

Fixes Issue: BB10-WebWorks-Framework#602

ejzn commented 11 years ago

A bit of a hacky change, but it keeps it low risk by not modifying the code for the *nx path. It only affects windows which is broken anyhow...

rwmtse commented 11 years ago

@erikj54 Curious, so what's the root cause?

ejzn commented 11 years ago

Hmm, I'm not sure this ever worked, since it seems that the path returned is quite different for windows and Mac, but the logic only really worked for Mac. But it was basically a difference of paths ../../FR_fr/icon having a split run on it, we were taking the first result in Mac, which would return FR_fr, but on windows it would return .. as the locale, not exactly valid.

ejzn commented 11 years ago

@tracyli Or @ishneur can you test packaging an app on both Windows and Mac for this? I can send you and app to try out.

ejzn commented 11 years ago

Closing will re-open.