Open ejzn opened 11 years ago
Same change needs to be made for the cordova repo as well @bhiggins advise please
Sent from my BlackBerry 10 smartphone.
From: Erik Johnson Sent: Wednesday, February 27, 2013 8:38 AM To: blackberry/BB10-Webworks-Packager Reply To: blackberry/BB10-Webworks-Packager Subject: [BB10-Webworks-Packager] Updating file path support for Windows 7 64 bit (#263)
You can merge this Pull Request by running
git pull https://github.com/blackberry-webworks/BB10-Webworks-Packager erik/i18n
Or view, comment on, or merge it at:
https://github.com/blackberry/BB10-Webworks-Packager/pull/263
Commit Summary
File Changes
Patch Links:
This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.
Tested on Windows 7 and XP. Both the icon and the splash screen change after changing the language.
patch applied to cordova repo
tested on winxp and mac: icon and splash screen worked well when changing the language.
bump.
@jkeshavarzi @jeffheifetz are there still concerns with this? it has been outstanding for a while now
@jkeshavarzi @jeffheifetz ?
Should this be closed now, or pulled in?
@tracyli @ishneur Can we get this regression tested on Windows 7/XP as well as Mac? We need to make sure that the localization icons are changing properly as well as the splash screens.