blackberry / BB10-Webworks-Packager

The BB10 WebWorks Packager bundles the App content with the BB10 WebWorks Framework to create a BAR to run on the BB10 Device (or simulator)
27 stars 18 forks source link

Updating file path support for Windows 7 64 bit #263

Open ejzn opened 11 years ago

ejzn commented 11 years ago

@tracyli @ishneur Can we get this regression tested on Windows 7/XP as well as Mac? We need to make sure that the localization icons are changing properly as well as the splash screens.

nukulb commented 11 years ago

Same change needs to be made for the cordova repo as well @bhiggins advise please

Sent from my BlackBerry 10 smartphone.

From: Erik Johnson Sent: Wednesday, February 27, 2013 8:38 AM To: blackberry/BB10-Webworks-Packager Reply To: blackberry/BB10-Webworks-Packager Subject: [BB10-Webworks-Packager] Updating file path support for Windows 7 64 bit (#263)


You can merge this Pull Request by running

git pull https://github.com/blackberry-webworks/BB10-Webworks-Packager erik/i18n

Or view, comment on, or merge it at:

https://github.com/blackberry/BB10-Webworks-Packager/pull/263

Commit Summary

File Changes

Patch Links:


This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

ishneur commented 11 years ago

Tested on Windows 7 and XP. Both the icon and the splash screen change after changing the language.

bryanhiggins commented 11 years ago

patch applied to cordova repo

tracyli commented 11 years ago

tested on winxp and mac: icon and splash screen worked well when changing the language.

ejzn commented 11 years ago

bump.

bryanhiggins commented 11 years ago

@jkeshavarzi @jeffheifetz are there still concerns with this? it has been outstanding for a while now

bryanhiggins commented 11 years ago

@jkeshavarzi @jeffheifetz ?

timwindsor commented 11 years ago

Should this be closed now, or pulled in?