search

blackberry / BB10-Webworks-Packager

The BB10 WebWorks Packager bundles the App content with the BB10 WebWorks Framework to create a BAR to run on the BB10 Device (or simulator)
27 stars 18 forks source link

No error if signing with -g but no -b, and version="x.x.x" and vice versa (no -g with a -buildId) #88

Closed erhorim closed 12 years ago

erhorim commented 12 years ago

Description: In config.xml, specify version="x.x.x" in <widget>. In cmdline, bbwp app.zip -g

Unsigned bar is produced but no error msg for missing -b

Acceptance criteria-

  1. if -g is specified and no buildId is specified throw an error saying - "No buildId specified"
  2. if --buildId is specified and no -g is specified throw an error saying - "No buildId specified" Build: http://mac-ci:9000/job/BB10-Webworks-Packager-next-fix12/3/
nukulb commented 12 years ago

what is -b ? typo? or do you mean buildId?

erhorim commented 12 years ago

-b is the short form for --buildId

See bbwp usage info: -b, --buildId Specifies the build number for signing (typically incremented from previous signing).

kwallis commented 12 years ago

I don't believe this existed in previous bbwp's. Any idea why this was added?

nukulb commented 12 years ago

@jkeshavarzi/ @kwhatmough might be able to shed some light on why this was added?

jamesjhedley commented 12 years ago

I basically coded signing in such a way that it only tries to sign when 3 conditions are met.

1) signing keys were found 2) password was provided (-g) 3) buildId was specified (--buildId or 4rth digit of version)

If we don't have the buildID then we don't bother to sign. I coded it this way because i thought it made the most sense.

If this is undesired [@kwallis], i can make the necessary code changes. (should be an easy fix)

nukulb commented 12 years ago

What is -b? It seems new for this release.

jamesjhedley commented 12 years ago

-b is the same as --buildId

This is just the way the node module we use for command line stuff works. The only way i was able to use a word as a command line parameter is with two dashes. (--) and single character commands are one dash. So the result is -b or --buildId for specifying build ids via command line.

nukulb commented 12 years ago

that makes sense, also is a lot like other command line tools.

kwallis commented 12 years ago

However, we are now changing the command line interface for no real sound reason, IMO? it used to be -buildId, we now have -b or --buildID, but NO -buildId?

Ken Wallis

Product Manager – BlackBerry WebWorks

Research In Motion

(905) 629-4746 x14369

From: Nukul Bhasin [reply@reply.github.com] Sent: Monday, April 16, 2012 3:18 PM To: Ken Wallis Subject: Re: [BB10-Webworks-Packager] No error if signing with -g but no -b, and version="x.x.x" (#88)

that makes sense, also is a lot like other command line tools.

Reply to this email directly or view it on GitHub: https://github.com/blackberry/BB10-Webworks-Packager/issues/88#issuecomment-5160111

This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

nukulb commented 12 years ago

I am confused, is this a typo or the interface is wrong?

nukulb commented 12 years ago

@kwallis and I had a discussion about correct behaviour here. It is unfair to deprecate -buildId (single dash) and not really inform the user properly.

spawned issue blackberry/BB10-Webworks-Packager#93

For this discussion- We want to throw an error if -g is specified with not --buildId or -b

Acceptance criteria-

  1. if -g is specified and no buildId is specified throw an error saying - "No buildId specified"
  2. if --buildId is specified and no -g is specified throw an error saying - "No buildId specified"

Accpetance criteria has been updated in the opening comment on the issue as well

jamesjhedley commented 12 years ago

We coded it this way because of a limitation on the node module we are using. However, we can probably code a workaround to support -buildId and internally convert it to --buildId so our node command-line module is happy.

kwallis commented 12 years ago

I think acceptance criteria number 2 should say that no signing password was provided?

----- Original Message ----- From: Nukul Bhasin [mailto:reply@reply.github.com] Sent: Monday, April 16, 2012 05:55 PM To: Ken Wallis Subject: Re: [BB10-Webworks-Packager] No error if signing with -g but no -b, and version="x.x.x" (#88)

@kwallis and I had a discussion about correct behaviour here. It is unfair to deprecate -buildId (single dash) and not really inform the user properly.

spawned issue blackberry/BB10-Webworks-Packager#93

For this discussion- We want to throw an error if -g is specified with not --buildId or -b

Acceptance criteria-

  1. if -g is specified and no buildId is specified throw an error saying - "No buildId specified"
  2. if --buildId is specified and no -g is specified throw an error saying - "No buildId specified"

Accpetance criteria has been updated in the opening comment on the issue as well

Reply to this email directly or view it on GitHub: https://github.com/blackberry/BB10-Webworks-Packager/issues/88#issuecomment-5163578

This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

kwallis commented 12 years ago

Understood, but we can't compromise user experience due to a technology choice we made.

----- Original Message ----- From: James Keshavarzi [mailto:reply@reply.github.com] Sent: Monday, April 16, 2012 06:16 PM To: Ken Wallis Subject: Re: [BB10-Webworks-Packager] No error if signing with -g but no -b, and version="x.x.x" and vice versa (no -g with a -buildId) (#88)

We coded it this way because of a limitation on the node module we are using. However, we can probably code a workaround to support -buildId and internally convert it to --buildId so our node command-line module is happy.

Reply to this email directly or view it on GitHub: https://github.com/blackberry/BB10-Webworks-Packager/issues/88#issuecomment-5163950

This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

jamesjhedley commented 12 years ago

Yup, no problem. I will figure out a solution tomorrow.

----- Original Message ----- From: Ken Wallis [mailto:reply@reply.github.com] Sent: Monday, April 16, 2012 06:55 PM To: James Keshavarzi Subject: Re: [BB10-Webworks-Packager] No error if signing with -g but no -b, and version="x.x.x" and vice versa (no -g with a -buildId) (#88)

Understood, but we can't compromise user experience due to a technology choice we made.

----- Original Message ----- From: James Keshavarzi [mailto:reply@reply.github.com] Sent: Monday, April 16, 2012 06:16 PM To: Ken Wallis Subject: Re: [BB10-Webworks-Packager] No error if signing with -g but no -b, and version="x.x.x" and vice versa (no -g with a -buildId) (#88)

We coded it this way because of a limitation on the node module we are using. However, we can probably code a workaround to support -buildId and internally convert it to --buildId so our node command-line module is happy.

Reply to this email directly or view it on GitHub: https://github.com/blackberry/BB10-Webworks-Packager/issues/88#issuecomment-5163950

This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

Reply to this email directly or view it on GitHub: https://github.com/blackberry/BB10-Webworks-Packager/issues/88#issuecomment-5164532

This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

erhorim commented 12 years ago

Defect fixed by blackberry-webworks/BB10-Webworks-Packager#15