search

blackberry / BB10-Webworks-Packager

The BB10 WebWorks Packager bundles the App content with the BB10 WebWorks Framework to create a BAR to run on the BB10 Device (or simulator)
27 stars 18 forks source link

Error occurs during compilation when widget id includes space #91

Closed tracyli closed 12 years ago

tracyli commented 12 years ago

Steps to reproduce:

  1. compile the attached zip file expected/Snarf: works fine fact: Error occurs - [Error: Please enter a valid application id.]
Build: http://mac-ci:9000/view/BB10/job/BB10-Webworks-Packager-next-fix-15-forth-time-event-registration/1/
Attachment: https://github.com/downloads/blackberry-webworks/BB10-Webworks-API/GHI14.zip
kwallis commented 12 years ago

@nukulb @rwmtse Is a space in the application id valid?

nukulb commented 12 years ago

By convention this should be reverse domain name so like com.mycompany.myapp so spaces are not valid by convention for sure. I don't think spaces are allowed but I will let @rwmtse confirm

rwmtse commented 12 years ago

The fact that the app can be packaged and works when the application id contains space means the OS apparently doesn't care about the space? So it's really up to us to decide what is a good convention to use.

In my opinion, the reasons I can think of to allow space are:

  1. to keep the same behavior with snarf
  2. application id needs to be the same for different versions of the same app? If we allowed space before and now we force them to not have it, that would force people to use a different application id for an already released app? And that will be a problem.

Otherwise it's better to eliminate space since they tend to cause issues.

kwallis commented 12 years ago

@rwmtse have you actually encountered a scenario where a space "causes and issue"?

@nukulb where does the convention of no spaces come from?

rwmtse commented 12 years ago

I don't think I have encountered an actual case where app id with space caused issues.

rwmtse commented 12 years ago

@kwallis I just saw this comment for id in the bar-descriptor.xml file in BB10 native SDK:

A universally unique application identifier. Must be unique across all BlackBerry applications. Using a reverse DNS-style name as the id is recommended. (Eg. com.example.ExampleApplication.) Required.

kwallis commented 12 years ago

We should provide this in our documentation as well as a recommendation. I don't necessarily want to enforce it though

kwallis commented 12 years ago

cc @caseden

kwallis commented 12 years ago

@caseden: When do you believe we can get a docs update out for this, to indicate that it is recommended that the id be a reverse DNS style name?

@rwmtse Will you be able to fix this for Beta2?

rwmtse commented 12 years ago

@kwallis Just to confirm that the fix is to allow space in id, correct? I think I can fix that.

caseden commented 12 years ago

We can put a suggestion in (to use the reverse domain format) probably by sometime next week.

kwallis commented 12 years ago

Correct, allow space

----- Original Message ----- From: Rosa Tse [mailto:reply@reply.github.com] Sent: Friday, May 11, 2012 01:53 PM To: Ken Wallis Subject: Re: [BB10-Webworks-Packager] Error occurs during compilation when widget id includes space (#91)

@kwallis Just to confirm that the fix is to allow space in id, correct? I think I can fix that.

Reply to this email directly or view it on GitHub: https://github.com/blackberry/BB10-Webworks-Packager/issues/91#issuecomment-5656950

This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.