Add cookies header that is added to regular requests.

blackberry / BlackBerry-Dynamics-React-Native-SDK

An open source plugin for BlackBerry Dynamics SDK with React Native support. BlackBerry Dynamics: https://developers.blackberry.com/us/en/products/blackberry-dynamics.html React Native: http://reactnative.dev

13 stars 18 forks source link

Add cookies header that is added to regular requests. #4

Closed ign699 closed 4 years ago

ign699 commented 4 years ago

Hi! Default RN fetch api attaches cookies to requests, but they are not attached by BB fetch implementation. This MR fixes this by adding Cookies header that is added to normal fetch requests as well, making the API more compliant with the original function.

Changes that were introduced:

Retrieve current cookies for domain from ForwardingCookieHandler
Add the cookies as Cookies header to the request if withCredentials is set to true.
Also, some whitespaces were removed in the process

volodymyrtaliar commented 4 years ago

Thanks, approved.

ign699 commented 4 years ago

Great so when will it get merged :)?

JeffinWithYa commented 4 years ago

@ign699 This pull request is currently go through our open source review process. I will update you when I have further information.