blackberry / DosBox

DosBox is a MS-DOS emulator used to play older games and applications meant to run on DOS.
GNU General Public License v2.0
59 stars 18 forks source link

Moving dosbox configuration file location #4

Closed jnicholl closed 12 years ago

jnicholl commented 12 years ago

By default, the location of the dosbox configuration file is inaccessible to users on the device. (NDK can access it, it's in the application sandbox.) This will move it to the shared directory, so it will be more accessible.

pelegri commented 12 years ago

Hi Jeremy. Doing a pass through the list of pull requests...

Are you waiting on somebody to review this request? Waiting on time to work more on it? Forgot about it?

jnicholl commented 12 years ago

Dosbox is already on AppWorld and I'm not sure anyone needs these changes at this point. I've been making more changes to SDL and wanted to confirm that they will work before pulling this in.

----- Original Message ----- From: Eduardo Pelegri-Llopart [mailto:reply@reply.github.com] Sent: Wednesday, March 21, 2012 12:50 AM To: Jeremy Nicholl Subject: Re: [DosBox] Moving dosbox configuration file location (#4)

Hi Jeremy. Doing a pass through the list of pull requests...

Are you waiting on somebody to review this request? Waiting on time to work more on it? Forgot about it?


Reply to this email directly or view it on GitHub: https://github.com/blackberry/DosBox/pull/4#issuecomment-4610934


This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

pelegri commented 12 years ago

NP. It's easier to not miss pull requests if we only keep the ones that are relevant, so if you think it is no longer applicable perhaps we should just close it? Its easy enough to reopen it again later.