blackberry / Ripple-Framework

A browser-like framework component that hosts the Ripple UI tooling and provides services required for emulation
Apache License 2.0
28 stars 12 forks source link

onRequest: request.url is null #3

Open dansilivestru opened 13 years ago

dansilivestru commented 13 years ago

Having the following in the container window:

window.onRequest = function (request) {
    if (request.url === "http://www.google.com") {
        request.deny();
    else {
        request.allow();
     }
};

And adding an image in the emulation window like this:

<img src="http://foo.com/img.jpg" />

request.url is null

expected request.url to be "http://foo.com/img.jpg"

ghost commented 13 years ago

fixed by adding back the line to set url before emitting onRequest event. It was not in the code on github

dansilivestru commented 13 years ago

Has it been checked in to a branch? and a pull request issued to the next branch?

ghost commented 13 years ago

yes

dansilivestru commented 13 years ago

Excellent. Sorry, I don't see the pull request anywhere? Also, do we have any test coverage for this?

dansilivestru commented 13 years ago

Ooops, Now I see it. Please ignore my last.