search

blackberry / Ripple-Framework

A browser-like framework component that hosts the Ripple UI tooling and provides services required for emulation
Apache License 2.0
28 stars 12 forks source link

Embed Web Inspector #30

Open tneil opened 13 years ago

tneil commented 13 years ago

Is there a specific reason why we launch web inspector up as its own floating window? Should we be embedding it at the bottom of the screen like Chrome does?

ericpearson commented 13 years ago

It maybe possible to embed the window, I think right now it's hard coded inside of QtWebView to open a new window. If we can figure out the URL it opens we could simply embed another QtWebView frame inside the one we have already (making it 3 browser instances). Will need to look into this one.

tneil commented 13 years ago

If we can figure out the URL... Even the ripple ui could open it in an iframe

Sent from my BlackBerry Smartphone

----- Original Message ----- From: Eric Pearson [mailto:reply@reply.github.com] Sent: Tuesday, September 20, 2011 06:44 PM To: Tim Neil Subject: Re: [Ripple-Framework] Embed Web Inspector (#30)

It maybe possible to embed the window, I think right now it's hard coded inside of QtWebView to open a new window. If we can figure out the URL it opens we could simply embed another QtWebView frame inside the one we have already (making it 3 browser instances). Will need to look into this one.

Reply to this email directly or view it on GitHub: https://github.com/blackberry/Ripple-Framework/issues/30#issuecomment-2150737

This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

ericpearson commented 13 years ago

I remember now why it's in a separate window. It's so the web inspector code does not block the rest of the JavaScript code in your page. It needs to run in a separate instance, I don't think embedding it in an iframe will work.

tneil commented 13 years ago

Ah.. Got it... Embedding the window at the bottom would be cool then

Sent from my BlackBerry Smartphone

----- Original Message ----- From: Eric Pearson [mailto:reply@reply.github.com] Sent: Tuesday, September 20, 2011 06:53 PM To: Tim Neil Subject: Re: [Ripple-Framework] Embed Web Inspector (#30)

I remember now why it's in a separate window. It's so the web inspector code does not block the rest of the JavaScript code in your page. It needs to run in a separate instance, I don't think embedding it in an iframe will work.

Reply to this email directly or view it on GitHub: https://github.com/blackberry/Ripple-Framework/issues/30#issuecomment-2150809

This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

ericpearson commented 13 years ago

This should be no problem to do, I have a proof of concept working.