blackberry / Ripple-Framework

A browser-like framework component that hosts the Ripple UI tooling and provides services required for emulation
Apache License 2.0
28 stars 12 forks source link

4.7 build is broken in blackberry-webworks #46

Open kwhatmough opened 12 years ago

kwhatmough commented 12 years ago

The following line in blackberry-webworks/Ripple-Framework breaks the 4.7 build: https://github.com/blackberry-webworks/Ripple-Framework/blob/next/Starbuck/starbuck.cpp#L54

ericpearson commented 12 years ago

WebGL isn't supported in 4.7.3, I will place an ifdef around this to fix the compiler error.

On Sat, Oct 1, 2011 at 11:02 AM, Ken Whatmough < reply@reply.github.com>wrote:

The following line in blackberry-webworks/Ripple-Framework breaks the 4.7 build:

https://github.com/blackberry-webworks/Ripple-Framework/blob/next/Starbuck/starbuck.cpp#L54

Reply to this email directly or view it on GitHub: https://github.com/blackberry/Ripple-Framework/issues/46

ericpearson commented 12 years ago

Should be fixed now, pushed the changes.

On Sat, Oct 1, 2011 at 11:53 AM, Eric Pearson pagefault@gmail.com wrote:

WebGL isn't supported in 4.7.3, I will place an ifdef around this to fix the compiler error.

On Sat, Oct 1, 2011 at 11:02 AM, Ken Whatmough < reply@reply.github.com>wrote:

The following line in blackberry-webworks/Ripple-Framework breaks the 4.7 build:

https://github.com/blackberry-webworks/Ripple-Framework/blob/next/Starbuck/starbuck.cpp#L54

Reply to this email directly or view it on GitHub: https://github.com/blackberry/Ripple-Framework/issues/46

ghost commented 12 years ago

Eric, Can you add webInternal->settings()->setWebSecurityEnabled(false) back before the ifdef. It is needed for showing pages inside the IFrame.

ericpearson commented 12 years ago

Oops, fixed it.