blackberry / Ripple-Framework

A browser-like framework component that hosts the Ripple UI tooling and provides services required for emulation
Apache License 2.0
28 stars 12 forks source link

Starbuck crashes when scrolling with main content window #56

Closed ndaversa closed 13 years ago

ndaversa commented 13 years ago

Steps to reproduce:

  1. Navigate to:
http://dl.dropbox.com/u/2623992/menu.html
  1. Open the config panel (or enough panels so that the main content window requires scrolling)
  2. scroll the main window until you reach the bottom

Actual Result: Starbuck crashes

Expected Result: No crash, just scrolling bliss, maybe some nice rubber banding at the bottom for good measure

[2092554]

ericpearson commented 13 years ago

I have found the issue, fixing it now.

ericpearson commented 13 years ago

Should be fixed now

On Thu, Oct 6, 2011 at 1:40 PM, Nino D'Aversa < reply@reply.github.com>wrote:

Steps to reproduce:

  1. Navigate to:
http://dl.dropbox.com/u/2623992/menu.html
  1. Open the config panel (or enough panels so that the main content window requires scrolling)
  2. scroll the main window until you reach the bottom

Actual Result: Starbuck crashes

Expected Result: No crash, just scrolling bliss, maybe some nice rubber banding at the bottom for good measure

[2092554]

Reply to this email directly or view it on GitHub: https://github.com/blackberry/Ripple-Framework/issues/56

ndaversa commented 13 years ago

Got a link to the commit that fixes it?

ericpearson commented 13 years ago

Testing it now. I'll let you know when i'm finished.

On Thu, Oct 6, 2011 at 2:31 PM, Nino D'Aversa < reply@reply.github.com>wrote:

Got a link to the commit that fixes it?

Reply to this email directly or view it on GitHub:

https://github.com/blackberry/Ripple-Framework/issues/56#issuecomment-2313325

ericpearson commented 13 years ago

I have pushed the fix it is commit fae36473e0feaa28e2baafa4b5bd550ef841adbb

ericpearson commented 13 years ago

This is good to go now. Please let me know if you have any issues related to scrolling.

ndaversa commented 13 years ago

Where can I get a build to test? (cc @dansilivestru @gtanner)

kwallis commented 13 years ago

Fixed