search

blackberry / SDL

Simple DirectMedia Layer is an open-source, cross-platform multimedia library designed to provide a low level API.
GNU Lesser General Public License v2.1
86 stars 46 forks source link

Redo the way TouchControlOverlay is included: #18

Closed absmall closed 12 years ago

absmall commented 12 years ago

-Don't hardcode directories in build_for_playbook.sh, make it a configure test, but require it to be found on playbook. -Don't include any paths for TouchControlOverlay - better to install it first and get it from the ndk stage than to assume it is built using momentics one directory up from the current directory. -Don't hardcode the build platform, this can easily be auto-detected by configure. -Remove explicit header include paths, library include paths, and variables that are unnecessary because configure will already set them up

absmall commented 12 years ago

I removed RANLIB, CPP, CC and LD because they're unnecessary, the NDK sets them already, and by hardcoding them, it prevents trying to compile for x86. I'd like to reduce the contents of build_for_playbook.sh to a minimum so that I can make a copy for x86 that just has what really needs to be in a separate script (the commands that make the build playbook or playbook simulator-specific) and not have to keep the rest of the contents in sync.

I removed some contents of CPPFLAGS and LDFLAGS because it assumes that TouchControlOverlay is one directory up, which I don't think is a good assumption. It doesn't mention that this has to be the case in the README.md, and I don't think that a relative build path for a dependent project that a project requires is a common assumption in other build systems. Also, it assumes the library path that momentics produces, which I don't think makes sense. A momentics build could assume the other project is built by momentics, but a command line build should if anything assume the other project is built on command line, not by momentics.