search

blackberry / WebWorks-API-Docs

BlackBerry WebWorks API Documentation
66 stars 47 forks source link

Added blackberry.payment BB10 api #447

Closed rwmtse closed 11 years ago

jeffheifetz commented 11 years ago

Have the docs not updated correctly? developmentMode seems to be missing BB10 support, but I see it in the file.

scdowney commented 11 years ago

Unfortunately, our SVV has uncovered another issue that must be addressed before we are comfortable with this going live. We are going to be investigating it tomorrow morning.

rwmtse commented 11 years ago

@jeffheifetz Were you looking at the github copy? Try this link instead

scdowney commented 11 years ago

Ash has pushed the fixed extension implementation to next-bb10-payments branch we had been working out of, but the documentation will need to be updated, as well as the unit tests, I believe.

rwmtse commented 11 years ago

@scdowney how about getPrice? I see that it takes skuOrId ...?

scdowney commented 11 years ago

That one is fine, actually. The implementation on the back end there doesn't have the same limitation  Sent from my BlackBerry 10 smartphone. From: Rosa TseSent: Wednesday, January 30, 2013 3:36 PMTo: blackberry/WebWorks-API-DocsReply To: blackberry/WebWorks-API-DocsCc: Shawn DowneySubject: Re: [WebWorks-API-Docs] Added blackberry.payment BB10 api (#447)@scdowney how about getPrice? I see that it takes skuOrId ...?

          —
          Reply to this email directly or view it on GitHub.
rwmtse commented 11 years ago

@scdowney: I see. But I think we should unify the signature... coz outside developers would only look at the signature

scdowney commented 11 years ago

@rwmtse Yeah, I agree. nice to keep it consistent between the two. we'll just have to do a bit more testing once the change is made, just to be absolutely sure getprice continues to work properly (though theres no reason why it shouldnt)

scdowney commented 11 years ago

will these have build anywhere yet? I wouldnt mind seeing them in the rendered form... its easy to miss stuff when just looking at code

scdowney commented 11 years ago

Just as a side note, our SVV are currently updating their app and testing the new changes, but Ash and I have also gone through a few tests on the new changes, and everything seems to be working OK. I can update more definitively once I hear from SVV, but its looking good

rwmtse commented 11 years ago

See the rendered docs here

scdowney commented 11 years ago

Awesome, thanks @rwmtse. Docs all look good to me, now. And SVV are just running tests now, I am told.

Just curious, what is the timeline for this once both pull requests are merged in, in terms of public release?

jeffheifetz commented 11 years ago

Merged Manually