blackberry / WebWorks-API-Docs

BlackBerry WebWorks API Documentation
66 stars 47 forks source link

Added two new error codes and a new callback pushserviceconnectionready for when the underlying Push Service goes down and the connection needs to be re-established. #458

Closed mdandrea closed 11 years ago

mdandrea commented 11 years ago

The two new error codes are: PUSH_SERVICE_CONNECTION_CLOSED and PUSH_SERVICE_CONNECTION_PERMISSION_ERROR. As well as two additional constants: CREATE_OPERATION and LAUNCH_APP_ON_PUSH_OPERATION.

The new callback is pushServiceConnectionReadyCallback.

\ Existing WebWorks applications will not be impacted by these changes. **

mdandrea commented 11 years ago

The API changes can be found here: https://github.com/blackberry/cordova-blackberry-plugins/pull/19

mdandrea commented 11 years ago

Note that these API doc changes will only be applicable to Cordova.

bryanhiggins commented 11 years ago

I have created a new "cordova" branch to capture these changes. Could you please close this and re-open against that branch?

mdandrea commented 11 years ago

@bryanhiggins Could you please give me read+write access to this repo and I'll make the change to be based off of the "cordova" branch. Thanks!

mdandrea commented 11 years ago

Or, I could make changes to a fork of the repo if that would be preferable I guess.

bryanhiggins commented 11 years ago

@mdandrea i don't actually have admin access. Just rebase your local branch off of blackberry/cordova and push to blackberry-webworks. Then create a pull request from blackberry-webworks to blackberry.

mdandrea commented 11 years ago

Closing. Have opened new pull request: https://github.com/blackberry/WebWorks-API-Docs/pull/465