search

blackberry / bbUI.js

BlackBerry UI look and feel JavaScript toolkit for WebWorks
Apache License 2.0
312 stars 192 forks source link

Screen size fix #1002

Closed listedegarde closed 10 years ago

listedegarde commented 10 years ago

Fix for the DAC shadow issue I mentioned in #975. I'm not quite sure why it looks like such a massive change. Is my encoding different, or something? I only moved the viewport tag check above the bb.device declarations and updated the BBui.js/css versions.

tneil commented 10 years ago

Hmm.. could be the way your CRLF are done in your editor

listedegarde commented 10 years ago

OK. It may be just best to close this issue then. Perhaps the CRLF is the cause of the extra space between the menubar and the shadow as well, thought it was definitely fixed by changing the order of the screen-size detection code in bbui.js, and was only visible on the DAC.

I only just got my dev computer back up and running after a couple months without it, so I haven't had time to do more experiments. I also have a lot of backlog of update requests for my apps that I should do before I continue debugging. At least put this down to low priority until someone else complains of the same issue or I have to do more thorough debugging.

tneil commented 10 years ago

Ok.. I'll make the changes in my copy of the code and push them in.. I'll close this issue for now.

tneil commented 10 years ago

I've checked in the changes into the 10.3 branch where I'm doing my current work