search

blackberry / bbUI.js

BlackBerry UI look and feel JavaScript toolkit for WebWorks
Apache License 2.0
312 stars 192 forks source link

#1007 fix-be CAREFUL before merge #1010

Closed MerrickZ closed 10 years ago

MerrickZ commented 10 years ago

I checked the source and found the size of screen menu image is 60x60 px and the caption is 16pt It seems fine but I still don't know why it shows as image 81x81 and caption 22pt. so I made some changes according to Tim Windsor's comment, and asked some z30 users to test the broken-menu-app with fix, they told me it works fine now.

so,be careful when merging, since I don't have a z30 device and can't test this out seriously.

Thank you @tneil. maybe @timwindsor can have this tested?

timwindsor commented 10 years ago

This moves it forward, but there's still a problem with the action bar. It uses the .bb-label-control-label style, which fixes it at 25pt font. If you change that value directly, it impacts the page CSS as well. The style for .bb-action-bar-action-display is where you would expect to set the value, but it's getting overridden by the label style.

MerrickZ commented 10 years ago

@timwindsor I changed the .bb-action-bar-action-display margin-top attribute from 5px to -5px and it seems fine on simulator, please have a check, thanks.

MerrickZ commented 10 years ago

I've added 2 functions to titleBar, the setAccentText() and setImage(), to change the title-bar image and accent text. Please review.

tneil commented 10 years ago

After adding a bunch of the 10.3 updates this pull request is no loner able to be automatically be merged.