search

blackberry / bbUI.js

BlackBerry UI look and feel JavaScript toolkit for WebWorks
Apache License 2.0
312 stars 192 forks source link

ImageList.refresh causes .remove and .insertItemBefore function useless #951

Closed gluth closed 11 years ago

gluth commented 11 years ago

Using refresh functions creates additional internal div element, between list and items, because of which during .remove script throws error (it is unable to find items array in parentNode, which is div inside of list).

Tested in Chromium, and on Z10.

tneil commented 11 years ago

I've marked this for the 0.9.6 milestone... Thanks for the pull request Jakub.. have you had a chance to submit a contributor agreement with BlackBerry yet? http://blackberry.github.io/howToContribute.html

gluth commented 11 years ago

I have just filled and sent ICLA. Waiting for confirmation.

tneil commented 11 years ago

Have you heard anything back at all yet?

gluth commented 11 years ago

Nope, it just sunked there, maybe it is connected into /dev/null? :)

tneil commented 11 years ago

I saw it come in on the group inbox.. I'll follow up to see if it has been reviewed

tneil commented 11 years ago

Ah.. just checked.. our main contributor review folks have been out of the office for the last day or two. Sounds like everything will be back to normal on Monday for reviewing contributor agreements

gluth commented 11 years ago

I think there should be a movie "Silence of the lawyers", still no info.

tneil commented 11 years ago

Pinged them again to see if they have reviewed it

tneil commented 11 years ago

Looks like they have reviewed it and it is good to go. They should be giving you the OK in an email shortly. I'll take a look at merging the pull request.

gluth commented 11 years ago

I have received green light, you can proceed with pull.

tneil commented 11 years ago

Sorry for taking so long on this one.. everything is merged in now. Thanks again for the contribution!