search

blackberry / jQueryMobile-BB10-Theme

jQuery Mobile BlackBerry 10 Theme
Apache License 2.0
72 stars 56 forks source link

added Pictures sample app #130

Open rdavidwu opened 11 years ago

astanley commented 11 years ago

David - thanks for this submission. I have reviewed and have 3 questions/requests:

1) It would be nice if the sample had a README that describes it in more details (what it is, what it does, who wrote it, how to troubleshoot / update, etc). 2) What is the copyright status for the photos you have included? 3) Can you update all HTML files to include the Apache2 header, and reference 2013 instead of 2012?

jasondscott commented 11 years ago

2) All of the images are wiki commons. img 1-3 were already in the project. Here are the links img 4,6,7 http://commons.wikimedia.org/wiki/File:Agilis_440_902_in_Regensburg.jpg http://commons.wikimedia.org/wiki/File:Opel_Ampera_2011-06-27.jpg http://commons.wikimedia.org/wiki/File:Montreal-Chez-la-mere-michel-luisricardo.jpg I can not find img 5 but I am pretty sure that it is commons. @rdavidwu will need to confirm

jasondscott commented 11 years ago

Technically - The code looks fine. I have not had a chance to run it though.