search

blackberry / webworks-gui

GUI Tool for WebWorks 2.0
https://developer.blackberry.com/html5/
Apache License 2.0
3 stars 5 forks source link

Added Linux support #21

Closed DanyiLin closed 10 years ago

DanyiLin commented 10 years ago

Fix issue: BRWSR-15402

bryanhiggins commented 10 years ago

No change needed to package.json?

DanyiLin commented 10 years ago

xml-mapping and pretty-data are required we also need add a file opener for linux in start-ui.js, currently we call "start" for windows and "open" for MacOS. I am adding gnome-open for linux, but the assumption is gnome is the default desktop for user's Linux, otherwise it maybe won't work. @rcruz what's your thought?

rcruz commented 10 years ago

gnome-open is fine for now. If we need further support, we can deal with it in the next release.

bryanhiggins commented 10 years ago

sensible-browser ?

rcruz commented 10 years ago

sensible-browser and xdg-open look like good alternatives too.

DanyiLin commented 10 years ago

I will switch to xdg-open, which is a more universal way and it works on both gnome and kde.

DanyiLin commented 10 years ago

@rcruz is start-ui sensitive to the version of xml-mapping and pretty-data? which version it should use?

I installed latest version of both modules, and seems good.

rcruz commented 10 years ago

I dont think they are particularly sensitive, but you can set the package.json to always install the version you currently have. You can check the version in node_modules//package.json

DanyiLin commented 10 years ago

@bryanhiggins @rcruz I tested and it works as expected on Linux. It's ready to merge

bryanhiggins commented 10 years ago

r+