Closed DanyiLin closed 10 years ago
No change needed to package.json?
xml-mapping and pretty-data are required we also need add a file opener for linux in start-ui.js, currently we call "start" for windows and "open" for MacOS. I am adding gnome-open for linux, but the assumption is gnome is the default desktop for user's Linux, otherwise it maybe won't work. @rcruz what's your thought?
gnome-open is fine for now. If we need further support, we can deal with it in the next release.
sensible-browser ?
sensible-browser and xdg-open look like good alternatives too.
I will switch to xdg-open, which is a more universal way and it works on both gnome and kde.
@rcruz is start-ui sensitive to the version of xml-mapping and pretty-data? which version it should use?
I installed latest version of both modules, and seems good.
I dont think they are particularly sensitive, but you can set the package.json to always install the version you currently have. You can check the version in node_modules/
@bryanhiggins @rcruz I tested and it works as expected on Linux. It's ready to merge
r+
Fix issue: BRWSR-15402