webworks build broken (debug, device)

[jsoref]

207 has broken the default workflow:

1. create project
2. click Build
3. click BUILD

Actual results: animated building... and then it goes away, nothing is built.

On OS X, there's "error: option '-k, --keystorepass ' argument missing" On Windows XP, there's no output.

[jamesjhedley]

@rcruz and i were looking into this.

It seems as though --keystorepass with an empty string does NOT actually prevent prompting like it does for --devicepass. In the GUI it prompts/hangs (release builds with no keystore pass or run with no keystore pass).

In my opinion there is also another issue here. Although it works as intended, i feel as though providing an empty string for --devicepass to prevent prompting is incorrect, since what it's actually doing is attempting to authenticate with the device with an incorrect password. Do this enough times and ur device get's wiped? Seems wrong. I understand the issue we are trying to resolve (prompting) just not sure this is the way to solve it.

[rcruz]

This is the current observed behaviour on OSX:

webworks build --keystorepass ""

• No prompt on terminal
• Builds succeeds, displays in GUI correctly

webworks build --release --keystorepass ""

• Prompts for keystore pass on terminal
• Build hangs on prompt, GUI hangs waiting for CLI

webworks run --keystorepass ""

• Prompts for keystore pass on terminal
• Build hangs on prompt, GUI hangs waiting for CLI

webworks run --release --keystorepass ""

• Prompts for keystore pass on terminal
• Build hangs on prompt, GUI hangs waiting for CLI

This shows that preventing terminal prompts cannot be achieved in all cases by passing --keystorepass "" to webworks CLI

[jsoref]

$ webworks build  --release --keystorepass "" --no-query
No signing password provided. You can omit --no-query, use --no-signing, use --keystorepass, or enter a value for 'keystorepass' in /Users/jsoref/.cordova/blackberry10.json

$ webworks build  --release --no-query
No signing password provided. You can omit --no-query, use --no-signing, use --keystorepass, or enter a value for 'keystorepass' in /Users/jsoref/.cordova/blackberry10.json

$ webworks run --no-query --release --devicepass $PASSWORD
 Device is not in the Development Mode. Switch to Development Mode from Security settings on the device.

$ webworks run --no-query --devicepass $PASSWORD
 Device is not in the Development Mode. Switch to Development Mode from Security settings on the device.

[bryanhiggins]

Moving to 2.1 milestone

We were originally going to check if project version > 3.4 for the --no-query option. It was decided it was easier to pass default values for keystorepass and devicepass. It appears that is not the case.

[bryanhiggins]

Here is my proposal: #224

[jamesjhedley]

I strongly recommend that for this release we at least make --keystorepass behave as --devicepass does (support for "" without hanging). I would rather it attempt to sign/generate a debug token with an incorrect keystorepass ("") then hang in the GUI. Hanging = gating in my opinion.

[bryanhiggins]

@jkeshavarzi we all agree on that (I hope)

There is no hanging with my patch applied.

[jamesjhedley]

@bryanhiggins Good good. Sorry, It sounded as though we may leave this for a future milestone. I misunderstood. Glad we are addressing it :).