Closed jengee closed 10 years ago
Does this cause an issue at package/runtime?
yes and no. For the most part it'll still build except in the scenarios where you have additional valid subdomains after it. In that scenario, the UI will return the following message in the builder log:
[INFO] Populating application source [INFO] Parsing config.xml
And return nothing else so the user is left wondering what just happened.
Node returns this message: stdout: [INFO] Populating application source [INFO] Parsing config.xml
stderr: /Users/jgee/WebWorks Projects/Project1/platforms/blackberry10/cordova/lib/logger.js:28 console.error("[ERROR] " + msg.replace(/error: /i, "")); ^ TypeError: Object Error: Invalid URI attribute in the access element - protocol required(rim.net) has no method 'replace' at Object.module.exports.error (/Users/jgee/WebWorks Projects/Project1/platforms/blackberry10/cordova/lib/logger.js:28:42) at Object.module.exports.start (/Users/jgee/WebWorks Projects/Project1/platforms/blackberry10/cordova/lib/packager.js:69:24) at build (/Users/jgee/WebWorks Projects/Project1/platforms/blackberry10/cordova/lib/build.js:121:39) at /Users/jgee/WebWorks Projects/Project1/platforms/blackberry10/cordova/node_modules/async/lib/async.js:548:21 at /Users/jgee/WebWorks Projects/Project1/platforms/blackberry10/cordova/node_modules/async/lib/async.js:224:13 at iterate (/Users/jgee/WebWorks Projects/Project1/platforms/blackberry10/cordova/node_modules/async/lib/async.js:131:13) at /Users/jgee/WebWorks Projects/Project1/platforms/blackberry10/cordova/node_modules/async/lib/async.js:142:25 at /Users/jgee/WebWorks Projects/Project1/platforms/blackberry10/cordova/node_modules/async/lib/async.js:226:17 at /Users/jgee/WebWorks Projects/Project1/platforms/blackberry10/cordova/node_modules/async/lib/async.js:553:34 at /Users/jgee/WebWorks Projects/Project1/platforms/blackberry10/cordova/lib/build.js:103:64
And even more so, once you get into this state, you can't remove the empty
So to truley fix the problem would be that the user physically goes into the config.xml and reload it into the UI (save everything elsewhere, delete it from the UI and reload it back into the UI)
For my previous comment, here are the steps to reproduce the scenario:
You should get a config.xml similar to this:
<content src="index.html"/>
<access origin="*"/>
<access subdomains="false"/>
<access subdomains="true"/>
<access subdomains="false"/>
<access subdomains="false"/>
<access origin="google.com" subdomains="false"/>
<access origin="" subdomains="false"/>
Duplicate of #39
Currently the UI accepts nothing as a value for the access list. The validator shall prevent users from adding values. building an app that contains no value as part of the access list will cause WebWorks to choke.