search

blackboxlogic / OsmApiClient

C# Client for the OSM API
MIT License
40 stars 5 forks source link

Fix OsmSharp's Data Model #4

Closed blackboxlogic closed 5 years ago

blackboxlogic commented 5 years ago

I'm fixing up OsmSharp's handling of xml responses. https://github.com/OsmSharp/core/issues/80 https://github.com/OsmSharp/core/issues/78 https://github.com/OsmSharp/core/issues/76

blackboxlogic commented 5 years ago

I think I've made all the changes that need to be made in the OsmSharp data model. If they don't want to merge the pull requests then I guess we're forking OsmSharp. TBD.

blackboxlogic commented 5 years ago

We still need to reference OsmSharp's nuget package, instead of including a fork of their sub-repo. Waiting for merge of https://github.com/OsmSharp/core/pull/82

blackboxlogic commented 5 years ago

Also, looking like we're still missing

HarelM commented 5 years ago

Gpx file scheme, reader and writer can be taken from NTS.IO.GPX. Which API method does the track belongs to? Wouldn't it be enough to use stream?

blackboxlogic commented 5 years ago

So... the data that comes back from GET /api/0.6/trackpoints?bbox=left,bottom,right,top&page=pageNumber is gpx version 1.0 and https://github.com/NetTopologySuite/NetTopologySuite.IO.GPX/issues/35

I've made https://github.com/openstreetmap/openstreetmap-website/issues/2350 but I'll probably not be able to use NTS.IO.GPX

blackboxlogic commented 5 years ago

After doing the work, I now see that just returning a stream is the right answer for both calls that get gpx data. Thanks for trying to save me the effort.

blackboxlogic commented 5 years ago

All major changes to OsmSharp are done. The data model now supports all calls to the API. Any further changes will be minor fixes.