search

blackcowmoo / grafana-google-analytics-datasource

Grafana Google Analytics datasource
https://grafana.com/grafana/plugins/blackcowmoo-googleanalytics-datasource/
Apache License 2.0
37 stars 17 forks source link

Last 30 days timepicker incorrect #99

Closed reuvygroovy closed 10 months ago

reuvygroovy commented 10 months ago

Describe the bug When choosing the "last 30 days" (or the like) in the timepicker the start date isn't processed correctly, but instead shows 12 hours ago. But when I manually select the time period in the panel by using "hardcoded" dates, it works. Alternatively, when I use the "Explore" mode for the same panel then also the last 30 days works.

Grafana Version & Plugin Version Grafana v10.0.1 (5a30620b85) Chrome browser We are using the latest analytics datasource/plugin version

This is how it looks in a regular panel (incorrect): image

But when we view the same panel in "Explore" mode it does display it accurately: image

lcc3108 commented 10 months ago

The plug-in only accepts requests from grafana and outputs the result value.

Depending on the settings, the plug-in can decide whether to run the query anew or not. (However, the query is supposed to be executed when the time range is changed.)

Additionally, is it a case where the problem only occurs in my plug-in?

If that's right, could you tell me more information? Detailed reproducible instructions or videos, etc

If not, I think we should create an issue in Grappa or Repo.

reuvygroovy commented 10 months ago

This only happens with your plugin. Other plugins such as MySQL datasources work just fine.

See attached video.

Uploading google_grafana.mp4…

reuvygroovy commented 10 months ago

Uploading google_grafana.mp4…

reuvygroovy commented 10 months ago

I don't know if the vide was uploaded properly or not so let me know.

lcc3108 commented 10 months ago

It's only appearing during upload.

Or if you send it to my email, I'll check it out.

dlacocjf32@gmail.com

lcc3108 commented 10 months ago

Additionally, the plug-in does not appear to be up to date.

The latest version has Query mode as shown below.

Therefore, please attach the plug-in version as well.

Or please update it to see if it's resolved.

When I tested only on the latest version plug-in, it worked normally.

image
reuvygroovy commented 10 months ago

Updated to the latest version but that didn’t help

From: IM CHAECHEOL @.> Sent: יום ד 15 נובמבר 2023 17:06 To: blackcowmoo/grafana-google-analytics-datasource @.> Cc: author @.***> Subject: Re: [blackcowmoo/grafana-google-analytics-datasource] Last 30 days timepicker incorrect (Issue #99)

Additionally, the plug-in does not appear to be up to date.

The latest version has Query mode as shown below.

Therefore, please attach the plug-in version as well.

Or please update it to see if it's resolved.

When I tested only on the latest version plug-in, it worked normally. [Image removed by sender. image]https://user-images.githubusercontent.com/38449269/283157616-73e68030-ac02-4325-96ef-194ce0c67c2a.png

— Reply to this email directly, view it on GitHubhttps://github.com/blackcowmoo/grafana-google-analytics-datasource/issues/99#issuecomment-1812707197, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAKDQZS4DDJJBQBMIL2WOJDYETK35AVCNFSM6AAAAAA7MHNB62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJSG4YDOMJZG4. You are receiving this because you authored the thread.Message ID: @.***>

lcc3108 commented 10 months ago

I saw the video you sent me.

But it can't be reproduced.

Would it still not be renewed even if I proceed with the following?

  1. Create and configure new dashboards

  2. Click the Refresh button after changing the time

    Can you share the dashboard like the picture below so that I can reproduce it?

    image image
reuvygroovy commented 10 months ago

Attached export

With the time hard coded @.***

With the last 30 days @.***

Refresh doesn’t help

From: IM CHAECHEOL @.> Sent: יום ד 15 נובמבר 2023 19:12 To: blackcowmoo/grafana-google-analytics-datasource @.> Cc: Author @.***> Subject: Re: [blackcowmoo/grafana-google-analytics-datasource] Last 30 days timepicker incorrect (Issue #99)

I saw the video you sent me.

But it can't be reproduced.

Would it still not be renewed even if I proceed with the following?

  1. Create and configure new dashboards
  2. Click the Refresh button after changing the time

Can you share the dashboard like the picture below so that I can reproduce it? [image]https://user-images.githubusercontent.com/38449269/283194539-92898e96-5e52-431a-9572-e45d748f9aaa.png [image]https://user-images.githubusercontent.com/38449269/283194932-16fca5dc-f61c-4087-a4b8-0ae2f0b81e45.png

— Reply to this email directly, view it on GitHubhttps://github.com/blackcowmoo/grafana-google-analytics-datasource/issues/99#issuecomment-1812937090, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAKDQZXU7UYCDRAPJPWSDCLYETZXTAVCNFSM6AAAAAA7MHNB62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJSHEZTOMBZGA. You are receiving this because you authored the thread.Message ID: @.**@.>>

lcc3108 commented 10 months ago

@reuvygroovy Dashboard json file is not attached.

reuvygroovy commented 10 months ago

[Uploading ABC123-1700111347882.json…]()

reuvygroovy commented 10 months ago

Attached. Let me know if you got it

lcc3108 commented 10 months ago

Yes, I received it through email.

I'll check.

lcc3108 commented 10 months ago

Remove Query options -> Relative time

Original

image

Fix

image
reuvygroovy commented 10 months ago

Awesome! Amazing! Sorry I made such a mistake :-(