blackcryll / artisan

Automatically exported from code.google.com/p/artisan
0 stars 0 forks source link

artisan read invalid temperature from MS6514 #81

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

What steps will reproduce the problem?
1. connect MS6514
2. START logging
3. monitoring Graph - and sometimes read above 300 degree.

What is the expected output? What do you see instead?

What version of the product are you using? On what operating system?
artisan 0.9.2, windows 7 x64

Please provide any additional information below.

MS6514 send 18 bytes packet at every second.
but artisan does not use packet buffering or syncronization.

so artisan sometimes read truncated packet.

I modified source code - main.py

MS6514 packet header is 0x65 0x14.
if temperature data was truncated,
read more packets and check again.

see attached file.

Original issue reported on code.google.com by eightbi...@gmail.com on 6 Apr 2015 at 12:15

Attachments:

GoogleCodeExporter commented 8 years ago
Thanks for your contribution! Excellent! I added your patch to the main trunk 
(not committed yet as I am traveling). It will be part of the next release.

Original comment by luther.m...@gmail.com on 7 Apr 2015 at 9:54

GoogleCodeExporter commented 8 years ago
This is a new patch for MS6514.
Sometimes my notebook was received wrong packet from MS6514. (see attached 
image)

- Even if artisan received a wrong packet, returns the previous temperature so 
that the graph is drawn well.

- Regardless of the display option in MS6514, always send to T1 T2 order.

Original comment by eightbi...@gmail.com on 12 Apr 2015 at 4:21

Attachments:

GoogleCodeExporter commented 8 years ago
Thanks for this updated patch. I took it as is and will commit it soon to the 
repository (just moving to Github).

Original comment by luther.m...@gmail.com on 16 Apr 2015 at 7:46