search

blackd / Inventory-Profiles

Take control over you inventory. Sort. Move matching/all Items. Throw all/all items. Locked slots. Gear sets! And much more!
https://inventory-profiles-next.github.io/
GNU Affero General Public License v3.0
152 stars 50 forks source link

Crash with clientcommands - LockedSlotKeeper assumes container doesn't change #324

Closed Earthcomputer closed 1 year ago

Earthcomputer commented 1 year ago

Hi, I've looked briefly into a crash reported to clientcommands here and I think there is an issue in LockedSlotKeeper where it implicity assumes the container doesn't change by storing some slot ids, although I didn't fully understand what's going on yet. Clientcommands changes the open container when a container GUI is opened here. I was wondering if you could provide some insight into what's going on?

To reproduce, install clientcommands and inventory profiles next, join a world, place some dirt in a chest, then type /cfinditem dirt into chat.

blackd commented 1 year ago

Yeah LockedSlotsKeeper is a mess I'm trying to make my self clean for a long time. It should detect if a GUI is open and stop doing any thing until it's closed. But my guess is it happens to fast to be detected. The assumption is that i works on the normal player inventory which is available even if it's not open.

FlameUser706 commented 1 year ago

Oh my lord, the reason for the crashes was the version difference, updating libIPN and Inventory Profiles Next solved the issue Edit: Welp, maybe not-

blackd commented 1 year ago

Well I'm happy it's fixed 😁

I have the new version spam on startup for a reason 🤣

edit Well it sounded too good lol

FlameUser706 commented 1 year ago

Yeaaaah, I was kinda afraid that it wasn't going to be easy... do you want to chat on Discord so we're not clogging Github?

blackd commented 1 year ago

yeap

FlameUser706 commented 1 year ago

Alright FlameUser706#5060

blackd commented 1 year ago

https://discord.gg/23YCxmveUM

blackd commented 1 year ago

Soo the cause was pinned down to.... drumroll...

the server being paper.

blackd commented 1 year ago

"Fix/Workaround" will be available in the next release. However 1.19.3 is no longer supported and will not receive the fix.