search

blackd / Inventory-Profiles

Take control over you inventory. Sort. Move matching/all Items. Throw all/all items. Locked slots. Gear sets! And much more!
https://inventory-profiles-next.github.io/
GNU Affero General Public License v3.0
152 stars 50 forks source link

"Move all items" does not work with Crafting Tables #348

Closed unilock closed 1 year ago

unilock commented 1 year ago

Have you asked for help on discord?

NO

Minecraft Version/s

1.19.2, 1.20.1

Modloader

Fabric, Forge, Quilt

Modloader Version

Fabric: 0.14.22 Forge: 43.2.14 Quilt: 0.20.0-beta.11

Operating System

macOS

List of all other installed mods

Fabric 1.20.1:

Forge 1.19.2:

Quilt 1.20.1:

Describe the problem

When using the "Move All Items" hotkey in a Crafting Table, only one stack of items is transferred rather than all possible stacks of items.

(Note that, during testing, I had the "Only focused Item type" hotkey set to the same keybinding as "Move All Items", in order to only move the type of item my mouse cursor was hovering over. However, removing this keybind had no effect on the issue described here.)

Steps to reproduce

  1. Enter a singleplayer world in creative mode.
  2. Give yourself several stacks of the same item, for example, 3 stacks of Cobblestone.
  3. Open a Chest.
  4. Press the "Move All Items" hotkey while hovering over the Cobblestone in your inventory. The default is R + T.
  5. All 3 stacks of Cobblestone are moved to the chest.
  6. Move the Cobblestone back to your inventory.
  7. Open a Crafting Table.
  8. Press the "Move All Items" hotkey while hovering over the Cobblestone again.
  9. Only 1 stack of Cobblestone is moved.

I have tried to reproduce the problem with only or without "Inventory Profiles Next" and its dependencies installed.

blackd commented 1 year ago

works as intended.

if you feel that this is not the proper behaviour feel free to talk to us on discord.

unilock commented 1 year ago

No, I'd rather not join yet another Discord server for something so menial. If this is a "wontfix", then it looks like Mouse Wheelie has this feature - I'll just use that instead.

blackd commented 1 year ago

well as you wish. I prefer direct communication because I wish to understand the uses case behind the request and how do people think something should behave.

unilock commented 12 months ago

Sorry, my last response was rude. I'm just prejudiced against when projects insist on all communication going through e.g. Discord, since it makes it much more difficult to index / search for information.

My use case, personally, would be when crafting large amounts of "storage blocks" at once, such as Hay Bales from Wheat or Blocks of Coal from Coal, both of which are materials I tend to accumulate extensively.

This feature would also be also useful when crafting large amounts of e.g. Chests, since I could simply fill the crafting table with Planks with one "move all" click and remove the center stack of Planks with another "quick move" click, instead of arduously clicking a stack of Planks and dragging right-click across the 8 relevant slots of the crafting interface, only to accidentally fill in the wrong slot, and have to make several more clicks to correct the recipe, only to have to repeat the process when going to craft even more Chests. (OK, maybe this is a little dramatic, but hopefully it gets my point across.)

I am aware of the "auto-crafting" checkbox, but it is slightly less convenient to use, since I keep it turned off by default (to avoid accidentally crafting several stacks of buttons or what have you), and because it has a tendency to not automatically refill the crafting input. (Maybe this warrants a second issue...)

blackd commented 12 months ago

Well IPNs auto crafting is not on by default. The default behaviour is to just refill the crafting grid. Sometimes it might not work due to the server not willing to process that many packets. This can be mitigated by setting Mod Setting->Wait ticks before next craft to something more then 1.

this is how I use the full auto crafting https://www.youtube.com/watch?v=BHEnDOWltsQ

blackd commented 12 months ago

And the reason I insist on discord is so I can asses the situation and decide if issue will be needed. Also the mod has so many options that it might be possible to "fix" some of the issues, caused by uncooperative servers, that might not need fixing in the general case.

blackd commented 11 months ago

@unilock this add on mod https://modrinth.com/mod/invtweaks-emu-for-ipn offers functionality to move items to the crafting grid

unilock commented 11 months ago

The problem I have with auto-crafting is that, when quickly repeatedly shift-clicking the crafting output to craft stacks at a time, the crafting input occasionally isn't automatically refilled. Is that something that might be fixed by increasing the auto-crafting tick delay?

As for InvTweaks Emu for IPN, it does "move all items" to the crafting grid, but it will only move up to a stack at a time - for example, if I have 4 slots of 16 cobblestone, all cobblestone will be transferred to the crafting grid, but if I have 5 slots of 16 cobblestone, only 4 of the 5 slots will be transferred. Is that a bug?

blackd commented 11 months ago

the crafting input occasionally isn't automatically refilled. Is that something that might be fixed by increasing the auto-crafting tick delay?

yes the delay is between the shift click and the attempt to restock the grid

blackd commented 11 months ago

if I have 4 slots of 16 cobblestone, all cobblestone will be transferred to the crafting grid, but if I have 5 slots of 16 cobblestone, only 4 of the 5 slots will be transferred. Is that a bug?

It's possible that is a bug can you describe the key combination you are using