search

blackducksoftware / hub-client-go

Hub Client for Go (golang)
Apache License 2.0
9 stars 19 forks source link

Added API Key support #29

Closed snelson-pp closed 5 years ago

snelson-pp commented 5 years ago

Added support for logging in via API Key, per https://github.com/blackducksoftware/hub-client-go/issues/5. Also added gock-based unit tests, and fixed an error in errors.go.

rrati commented 5 years ago

As far as I can tell with my limited knowledge of Go, it looks... reasonable? My main questions are:

  • Why are so many files in the diff to add this support?

Go dependencies were updated. Anything under the vendor directory is a dependency. Only a few files were actually changed and the rest of dependencies.

  • More generally, why are we maintaining a client for a completely separate language from the majority of the code base?

This client is used by opssight, which is written in Go, and a few other projects. With kubernetes and openshift written in Go, it is more and more likely there will be interest in using a native Go client.

rrati commented 5 years ago

IMO go code looks fine an consistent with other functions in the client. I would prefer someone review who is familiar with the API key support in Blackduck

rrati commented 5 years ago

Fixes #5