search

blackducksoftware / hub-client-go

Hub Client for Go (golang)
Apache License 2.0
9 stars 19 forks source link

Switch to gomodules #64

Closed mattfenwick closed 3 years ago

tandr commented 4 years ago

Might want to update readme to specify that it is now uses Go modules, and needs minimum Go's version to run tests.

mattfenwick commented 4 years ago

Hi everybody, thanks for the review :)

I'm going to leave this up for a while, I understand that switching to gomodules could break some things and I certainly don't want that!

If anybody's interested in seeing this merged sooner than later, drop a comment here and we can start the conversation on making this happen!

tandr commented 4 years ago

I actually think we should merge it the sooner the better.

tandr commented 3 years ago

@mattfenwick I cherry-picked your changes minus going go modules. Don't forget to rebase (or redo) :) I think once 1.16 is out, this needs to be converted to go modules.

fnxpt commented 3 years ago

+1 for go modules

mattfenwick commented 3 years ago

Hi @fnxpt @tandr I don't have bandwidth to get this over the finish line , if you want to pick this up feel free!

fnxpt commented 3 years ago

Created a new PR. @mattfenwick @tandr

tandr commented 3 years ago

if you have created a new MR, you might as well close this one if it is no longer relevant.

fnxpt commented 3 years ago

I think I don't have permissions to close it

tandr commented 3 years ago

78 supersedes this one