blackducksoftware / hub-detect

This is now deprecated. Please see synopsys-detect.

Apache License 2.0

38 stars 39 forks source link

fixing pip-inspector.py to work with pip v10+ (including v18) #305

Closed gsnyder2007 closed 6 years ago

gsnyder2007 commented 6 years ago

Pull Request template

Why this pull request:

See https://jira.dc1.lan/browse/IDETECT-832
pip v18 which was released Sunday, July 22, broke the hub-detect's pip-inspector.py and will cause hub-detect to fail - when run on python projects that use pip v18.

Changes proposed in this pull request:

This pull request proposes a (more future proof) fix for pip-inspector.py that works with pip 10, pip 18, and, assuming the pip team sticks with numerically ascending major version numbers going forward, should work for future versions as well. Assuming that the API endpoints we use in pip do not change also.

coveralls commented 6 years ago

Coverage remained the same at 23.013% when pulling 10e96ea25a8d07e6c7966cf063306e121411383d on IDETECT-832-pip-18-breaks-inspector into fda56dde1a6298a34fccf0e2779f11d89836a3e6 on master.