search

blackducksoftware / hub-detect

This is now deprecated. Please see synopsys-detect.
Apache License 2.0
38 stars 39 forks source link

Use BDS_JAVA_HOME when calling Signature Scanner #325

Closed joc0611 closed 5 years ago

joc0611 commented 6 years ago

Expected behavior

Fix

This is fixed in hub-common starting with version 38.2.0, so this issue can be fixed by updating the depency to hub-detect. Once hub-common is released, I can provide a PR if that helps.

stavvy-akamen commented 6 years ago

Thank you @joc0611 for following this through. Looping in @ekerwin to make sure we are on top of things.

joc0611 commented 6 years ago

AFAICS, the updated hub-common version is already used in master as of 45b6555. Thanks! Do you guys consider this as fixed or should I close the issue once 4.3.0 is publicly available?

ekerwin commented 6 years ago

Let's close it when 4.3.0 is publicly available, which should be soon.

joc0611 commented 6 years ago

@ekerwin I think, we have to wait for a version > 4.3.0. I found I bug in my first PR. See https://github.com/blackducksoftware/hub-common/pull/230

stavvy-akamen commented 6 years ago

@joc0611 we released 4.3.0 and 4.4.0 is code frozen and in QA now. Is the current 4.4.0 branch useful for you?

joc0611 commented 6 years ago

@akamen https://github.com/blackducksoftware/hub-common/pull/230 over at hub-common will eventually fix this issue. Once the resulting hub-common version is integrated in hub-detect, we can close the issue at hand I guess.

Originally we thought we can close it with the release of 4.3.0, but my initial fix turned out to be incomplete.

joc0611 commented 5 years ago

I guess we can close this. I successfully tested the fix with version 5.2.0