Fix DetectConfigurationFactory.java

blackducksoftware / hub-detect

This is now deprecated. Please see synopsys-detect.

Apache License 2.0

38 stars 39 forks source link

Fix DetectConfigurationFactory.java #356

Closed bryonglodencissp closed 5 years ago

bryonglodencissp commented 5 years ago

Greetings,

The function call will not have its intended effect because the positions of arguments in the constructor for DetectToolFilter do not match the ordering of the parameters:

excludedTools is passed to includedTools
includedTools is passed to excludedTools

Signed-off-by: Bryon Gloden, CISSP® cissp@bryongloden.com

taikuukaits commented 5 years ago

Good catch!

coveralls commented 5 years ago

Coverage remained the same at 28.668% when pulling e29f045f09396cdbf2bf924da348c6da74f157d2 on bryongloden:master into 53a31909e25309bddfdc12a7789024e9039b7323 on blackducksoftware:master.

taikuukaits commented 5 years ago

So it turns out the order the DetectToolFilter passed these same values to the IncludedExcludedFilter was also flipped. So this accidentally caused it to work. I fixed the DetectToolFilter to match the IncludedExcludedFilter, so this might get changed. But I think it all is improved.