Closed JBirdVegas closed 8 years ago
@psantos1113 lets get this sucker merged into 2.0.8 snap
This solution is along the right lines we need to address the grandchildren but this will only handle grandchildren. Even though this is intended for gradle, we have some examples internally of maven projects that contain great grandchildren of the parent. It is unlikely but possible that a project could potentially be a great, great, grandchild and so on. Therefore to walk the whole project tree we need to do so recursively. The getProjectDependencies most likely needs to call itself recursively in order to walk the tree. So the if statement that was added probably needs to be put into getProjectDependencies so that it calls itself recursively to walk the tree.
Good point I'll modify the PR. Have to be pretty careful if the build is too big using a recursive method call seems to cause an OOM.
@psantos1113, latest PR adds support for infinity projects in a build's reactor. This PR also completely avoids the complexity involved in nested loops and tail-end recursion while searching for all subprojects of subprojects.
@JBirdVegas the change looks good. I will merge the code change. Thank you for contributing.
Previously the plugin would only evaluate the
rootProject
's children projects. This works fine if the root's children are the actual projects in the case where the root's children are only a root for rootProjects's children's children, rootProject's grand children, this is not enough.Now for each child project of root we check for subproject of the children.
If grand children project's are found then add their dependencies to the report