search

blackducksoftware / hub-rest-api-python

HUB REST API Python bindings
Apache License 2.0
89 stars 104 forks source link

Example script for filtering BD notifications. Upload to dev branch f… #231

Closed nichollsdave closed 1 year ago

nichollsdave commented 1 year ago

Hi Koishi-san,

I have reviewed this and it looks great, I also pulled the branch and tested it locally but not an exhaustive test and it works well. I can see how this could be useful.

Only comment I have is at the moment if there is any network 'glitch' during the running (i.e. setting a notification to 'seen' it will exit and not continue. It is debatable what is preferred with this but it is feasible if updating 1000s of notifications that the odd one may hit a network issue and we might want it to continue. On the flip side if they are all failing its just a big mess of failed requests. I'll leave it up to you if you leave as is or handle individual errors.

Great work.

koshmack commented 1 year ago

I will fix the error handling which is suggested by the reviewer.