search

blackducksoftware / ohcount

The Ohloh source code line counter
https://github.com/blackducksoftware/ohcount
GNU General Public License v2.0
261 stars 69 forks source link

Add Puppet parameterized classes #39

Closed wcooley closed 5 years ago

wcooley commented 10 years ago

This change expands one of the regular expressions used to disambiguate Puppet and Pascal files ending with ".pp". Without this, parameterized Puppet classes do not match and end up being detected as Pascal.

I have confirmed that with this change ohcount matches everything in my Puppet tree that it matched with the previous, plus all that it should have matched, save one -- a file with nothing but comments & blank lines.

Running ohcount -d on the existing and newly-added files test/detect_files/puppet_*.pp detects them as Puppet files (except for the __annotated_ ones, which aren't actually Puppet anyway); it also does not erroneously detect anything as Puppet.

I attempted to run ./build tests, but it core dumps on both master and this branch.

wcooley commented 10 years ago

_tap_tap* Anybody home?

notalex commented 5 years ago

We did some work in https://github.com/blackducksoftware/ohcount/commit/f02286ea7e3ace0465258dfe00b88c8465a387a9#diff-d77fa1db75cc45114696de9b1c005b26 to fix puppet/pascal detection. Please reopen if this issue is still not fixed.