search

blackducksoftware / ohcount

The Ohloh source code line counter
https://github.com/blackducksoftware/ohcount
GNU General Public License v2.0
261 stars 69 forks source link

More test cases for comments in .bat #5

Closed dolmen closed 12 years ago

dolmen commented 13 years ago

Here are a few more test cases for MS batch files.

robinluckey commented 12 years ago

Hi dolmen,

Thank you for submitting this patch.

I know it has been a very long time. We are planning to deploy a new version of Ohcount to the Ohloh website soon, so I am finally going through all of the outstanding pull requests.

For this patch, you have submitted tests only. Currently, these tests do not pass. Was this what you expected?

If so, I can take a few minutes to update Ohcount's internals to make sure that these tests pass. It shouldn't take very long.

I just want to be sure that the patch you submitted is incomplete, and intentionally so.

Thanks, Robin

dolmen commented 12 years ago

Hi Robin.

I confirm. This pull request provides only a few more test cases. I have no patch as this project as this project is in Ruby. I'm more a Perl guy.

Olivier.

robinluckey commented 12 years ago

Great -- I've updated our batch file parser to accept all of the new variants as comment delimiters. Thanks!

dolmen commented 12 years ago

Next time, please merge the commit instead of copying it. This would have preserved credits. Being at Ohloh, you should know how a commit in a project impacts Ohloh ranking.

robinluckey commented 12 years ago

Hi dolmen,

I'm sorry your name was lost from the git log. This was not my intention, and you deserve credit for your help.

Your original patch did not include any source code, and the test file you submitted was incorrectly delimited (tabs vs spaces) so I had to replace that as well. After all the hacking was completed it was easier to just submit a completed patch.

I know this doesn't lessen the crime, but because your patch did not include any source code, it would not have been counted in the Ohloh report anyway.

Apologies, Robin