Fix build on RHEL7 - Githubissues

blackducksoftware / ohcount

The Ohloh source code line counter

https://github.com/blackducksoftware/ohcount

GNU General Public License v2.0

257 stars 74 forks source link

Fix build on RHEL7 #70

Closed jrgp closed 4 years ago

jrgp commented 5 years ago

Fix the following error during build:

languages.gperf:72:1: error: conflicting types for ‘ohcount_hash_language_from_name’
In file included from languages.gperf:2:0:
src/hash/../languages.h:129:21: note: previous declaration of ‘ohcount_hash_language_from_name’ was here
 struct LanguageMap *ohcount_hash_language_from_name(register const char *str, register size_t len);

I'm on RHEL7 7.3 with gcc 4.8.5. Maybe a newer gcc is lets unsigned int be used interchangeably with size_t ?

notalex commented 5 years ago

Thank you for your contribution. I will test this out with the other supported distros and push out a release soon.

PDegenPortnoy commented 4 years ago

Work that needs to be done to verify:

Get a copy of RHEL7 7.3
Install gcc 4.8.5 and verify it builds, passes tests and appears to work correctly
Install latest gcc (9.2) and repeat the process
Repeat process testing with gcc 9.2 on Ubuntu 18.04 LTS, which is our current production environment.

notalex commented 4 years ago

@jrgp, I apologize for the delay in responding to this. We have tested this fix against Ubuntu 18.04 with the newer gcc. The newer gcc would not work with these changes, so we will not be able to accept your contribution as it is right now. You could consider upgrading your gcc to make ohcount work on RHEL7.

Verified that this fix works for RHEL7 with gcc 4.8.5.
Verified that this build fails on Ubuntu 18.04 with gcc 7.4

jrgp commented 4 years ago

@notalex no worries, thanks for your response.