blackducksoftware / perceivers

Kubernetes and openshift image discovery for OpsSight
Apache License 2.0
4 stars 7 forks source link

Long image names: unable to update annotations/labels for pod... must be no more than 63 characters #61

Closed sheppduck closed 6 years ago

sheppduck commented 6 years ago

The perceiver can come across images with long names and the following error is throw in the log: time="2018-04-18T17:21:19Z" level=error msg="unable to update annotations/labels for pod openshift-template-service-broker:apiserver-lz5tb: Pod \"apiserver-lz5tb\" is invalid: metadata.labels: Invalid value: \"registry.access.redhat.com.openshift3.ose-template-service-broker\": must be no more than 63 characters"

Looks like we should maybe be ignoring the registry name, if possible?

jayunit100 commented 6 years ago

Just do the first 63 characters and be done with it.

jayunit100 commented 6 years ago

@msenmurugan has a simple fix for this, should we merge it?

rrati commented 6 years ago

@jayunit100 No, that fix doesn't really fix things. It can result in meaningless values. Please just hold off until we reproduce for the proper fix

rrati commented 6 years ago

closed via #62