restart pods for all security context changes (unless during upgrade)

blackducksoftware / synopsys-operator

Archived and moved this to https://github.com/blackducksoftware/synopsysctl

Apache License 2.0

10 stars 14 forks source link

restart pods for all security context changes (unless during upgrade) #1188

Closed mphammer closed 4 years ago

mphammer commented 4 years ago

always restart for security contexts unless updating without persistent storage because the pods will be restarted anyways due to the update
you need to restart the pods without persistent storage because the crudupdater doesn't have a diff to apply the security context changes to the pods

yashbhutwala commented 4 years ago

This is a rare case (no persistent volumes, but you want to run as non-root, and you want to change from previous non-root user to a different non-root user). Like we have mentioned, no persistent volumes is actually not supported for production.

But awesome, that you thought about this edge case, and we are handling it 😄

/lgtm

operator-r2d2 commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mphammer, yashbhutwala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/blackducksoftware/synopsys-operator/blob/release-2019.12.x/OWNERS)~~ [mphammer,yashbhutwala] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

yashbhutwala commented 4 years ago

/cherrypick master

operator-r2d2 commented 4 years ago

@yashbhutwala: new pull request created: #1189

In response to [this](https://github.com/blackducksoftware/synopsys-operator/pull/1188#issuecomment-575279590): >/cherrypick master Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.