search

blackducksoftware / synopsys-operator

Archived and moved this to https://github.com/blackducksoftware/synopsysctl
Apache License 2.0
10 stars 14 forks source link

updated the correct version of nginx and upload cache for Black Duck 2020.2.1 #1307

Closed msenmurugan closed 4 years ago

msenmurugan commented 4 years ago

resolves #1306

mphammer commented 4 years ago

This change should be cherry-picked into "develop" branch too :)

yashbhutwala commented 4 years ago

interesting, that the helm chart had these images correct. Although I see a difference between logstash versions, see here: https://github.com/blackducksoftware/hub/blob/master/kubernetes/blackduck-helm/values.yaml#L238

msenmurugan commented 4 years ago

/cherrypick develop

operator-r2d2 commented 4 years ago

@msenmurugan: once the present PR merges, I will cherry-pick it on top of develop in a new PR and assign it to you.

In response to [this](https://github.com/blackducksoftware/synopsys-operator/pull/1307#issuecomment-607295127): >/cherrypick develop Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
operator-r2d2 commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msenmurugan, yashbhutwala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/blackducksoftware/synopsys-operator/blob/release-2020.2.x/OWNERS)~~ [msenmurugan,yashbhutwala] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yashbhutwala commented 4 years ago

interesting, that the helm chart had these images correct. Although I see a difference between logstash versions, see here: blackducksoftware/hub:kubernetes/blackduck-helm/values.yaml@master#L238

turns out the helm chart has the incorrect value, but this is fine as 2.x version of the published helm chart is alpha support and not expected to be used much. this will be fixed in 4.x release of the helm chart.

operator-r2d2 commented 4 years ago

@msenmurugan: new pull request created: #1308

In response to [this](https://github.com/blackducksoftware/synopsys-operator/pull/1307#issuecomment-607295127): >/cherrypick develop Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
msenmurugan commented 4 years ago

/cherrypick saas-2020.2.3

operator-r2d2 commented 4 years ago

@msenmurugan: new pull request created: #1313

In response to [this](https://github.com/blackducksoftware/synopsys-operator/pull/1307#issuecomment-607467731): >/cherrypick saas-2020.2.3 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.