search

blackears / cyclopsLevelBuilder

A Godot plugin to let you block in levels inside the Godot editor.
MIT License
920 stars 36 forks source link

Cannot editor move camera in block modifying modes #150

Closed CpazR closed 2 months ago

CpazR commented 3 months ago

When any of the following modes are selected: 2024-03-24 00_45_59-(_) level_0 tscn - bb-godot-prototype - Godot Engine

The camera cannot be moved.

This is a significant workflow hindrance, especially since there are no hotkeys to swap modes easily (at least none that are clearly documented as far as I could find). Maybe I'm missing something about the intended workflow, but I'm unsure why moving the camera wouldn't be allowed.

blackears commented 3 months ago

If you mean the viewport camera, you can middle click and drag to rotate the viewport or shift-middle click drag to pan side to side. You can also mousewheel to zoom the camera. All three of these tools are designed to do this and it works for me. Are you unable to do this?

darkhog commented 3 months ago

He meant rightclick+wsad to move around the level (wsad doesn't work with middle click).

CpazR commented 2 months ago

If you mean the viewport camera, you can middle click and drag to rotate the viewport or shift-middle click drag to pan side to side. You can also mousewheel to zoom the camera. All three of these tools are designed to do this and it works for me. Are you unable to do this?

Right, sorry. @darkhog is correct. I'm referring to right clicking and WASD.

aranasaurus commented 2 months ago

yeah working on a laptop here... no middle click makes things really difficult :(

blackears commented 2 months ago

The tools just pass the middle mouse click along to Godot for navigation. How are you used to rotating the camera when you're using a laptop?

aranasaurus commented 2 months ago

Right click + wasd. Sorry my comment is confusing in retrospect. I meant it was hard to navigate using these tools because I have no middle click. With right click causing the cancellation of the last operation in these tools it's cumbersome to have to exit the tool in order to move the camera, because I don't have the middle click as an option.

blackears commented 2 months ago

Sorry about that - I fixed this for the other tools but not the ones @CpazR mentioned. I just checked in a new fix that addresses this.

darkhog commented 2 months ago

Check if the paint materials tool suffer from this issue, just to be sure. Then I think it can be closed. BTW. love the hard work you're putting it to make this tool great. Cheers!

blackears commented 2 months ago

Right click fly is working with the other tools too. I'm going to close this. Please reopen if you're still having troubles.

CpazR commented 2 months ago

Not going to re-open, because I'm not 100% sure if this is a legit issue.

But this seems to be working mostly well with the new changes. In that it actually accepts this movement. The only question I have is if this is supposed to work more cleanly with the right-click to undo. Because that's still an issue for me.

If not, maybe rebind the undo to require the shift key? Or have the option be toggle-able somehow?

I've been able to make a temporary workaround by simply commenting out the cmd_xform_blocks.undo_it() call wherever the "Right click cancel" comment was left. Not a perfect solution, but it works mostly how I would expect.

Curious to know if this is an issue for anyone else or if I'm missing something?

blackears commented 2 months ago

My thinking was the you should not be trying to reposition the camera in the middle of an edit operation. I can understand wanting to right-click fly when you're not actively editing something, but moving the camera when you are could have weird side effects.

CpazR commented 2 months ago

Maybe I'm just missing something, but is there a way you're supposed to "finalize" an edit operation without de-selecting and re-selecting the tool? Because in the event I need to make multiple edits to the same mesh, I'll likely need to move the camera too.

I can understand wanting to right-click fly when you're not actively editing something, but moving the camera when you are could have weird side effects.

Also an aside to this point, so far with my very hacky workaround, it doesn't mess anything as far as I can tell.

blackears commented 2 months ago

The tool switches between various states as you use it. When it's in the READY state, it's effectively between operations and safe to fly. When you're in the middle of dragging something, it isn't. So as long as you are not currently clicking and dragging a point, you should be able to move around. The vertex move action is committed every time you release the mouse button.

darkhog commented 2 months ago

Except there's still a problem with pressing the RMB undoing your hard work. Yes, even on 1.0.3

blackears commented 2 months ago

I've just checked in a change for 1.0.4 so that shouldn't happen any more.