search

blackears / svgSalamander

154 stars 56 forks source link

Use Java 8 as minimum requirement? #63

Closed DevCharly closed 2 years ago

DevCharly commented 4 years ago

Currently svgSalamander is compiled for Java 6. See:

https://github.com/blackears/svgSalamander/blob/157a618c92fa692508129afa1114cb4b61e2125f/svg-core/pom.xml#L46-L47

But it already uses Java 8 API java.util.List.sort(Comparator) in class Gradient. See: https://github.com/blackears/svgSalamander/blob/157a618c92fa692508129afa1114cb4b61e2125f/svg-core/src/main/java/com/kitfox/svg/Gradient.java#L167

So svgSalamander maybe runs on Java 6 but probably fails as soon as gradients are used?

Would it be OK to change the minimum required Java version to 8 and benefit from "new" features like lambdas, try-with-resources, etc.?

If yes, I could create a PR.

Java 6 reached "end of public updates" in 2013.

DevCharly commented 2 years ago

Solved since commit 2b85be6cef0c7f9142d5521ec7cb50765229f271