search

blackfireio / lando-plugin

Lando plugin to use Blackfire
4 stars 3 forks source link

lando + platformsh recipe, `app_service` key #4

Open gilzow opened 2 years ago

gilzow commented 2 years ago

Not sure if this is a plugin issue or a documentation issue.

The default config value for app_service in services/blackfire/builder.js is appserver. When using a platform recipe, the default name of the project is app. The docs for using blackfire with lando omit mentioning the need to add the app_service key with the name of the main app if it differs from appserver. If this key is left out, then appService at line 47 is undefined as there is no app service named appserver causing line 48 to throw a fatal error.

It may be possible to get the default app service name and use it as the default for blackfire's app_service property, but I would need to dig into the lando code to be sure.

lolautruche commented 2 years ago

This is more a doc issue, but I guess your PR #5 fixes both 🙂 .