search

blackfireio / php-sdk

The Blackfire PHP SDK
https://blackfire.io
MIT License
150 stars 22 forks source link

Fix PHP 5.3 compatibility in Guzzle Middleware #22

Closed echernyavskiy closed 7 years ago

echernyavskiy commented 7 years ago

Fixes https://github.com/blackfireio/php-sdk/issues/20.

GrahamCampbell commented 7 years ago

Guzzle requires php 5.4+ though doesn;t it?

echernyavskiy commented 7 years ago

@GrahamCampbell that's right, though technically Guzzle 3.x was PHP 5.3 compatible. That's why I asked if maintainers would be interested in this change. One could make a point that if php-sdk declares itself compatible with PHP 5.3 in composer.json, all of its components should be compatible as well.

This also addresses your point in https://github.com/blackfireio/php-sdk/pull/21

romainneutron commented 7 years ago

No need for this piece of code to be compatible with PHP 5.3. Blackfire PHP SDK is PHP 5.3 compatible, it does not imply that all code provided by this package needs to be 5.3 compatible. As mentioned by @GrahamCampbell , you can not use the Guzzle Middleware on PHP 5.3.