search

blackfireio / php-sdk

The Blackfire PHP SDK
https://blackfire.io
MIT License
150 stars 22 forks source link

Blackfire and Xdebug clash #69

Closed derickr closed 8 months ago

derickr commented 8 months ago

Hi,

in https://bugs.xdebug.org/view.php?id=2230 you see that there are issues with blackfire and Xdebug. I can't reproduce this. So perhaps you can?

cheers, Derick

iamluc commented 8 months ago

Hi @derickr, Thanks for your report. I'll try to reproduce and let you know.

derickr commented 8 months ago

Cheers - feel free to find me on the foundation slack (I can invite you), or Room 11 (https://chat.stackoverflow.com/rooms/11/php) if you want to chat!

derickr commented 8 months ago

Does Blackfire use observers? And perhaps, removes it's own hook (like datadog trace did: https://github.com/DataDog/dd-trace-php/pull/2469 )

iamluc commented 8 months ago

Blackfire can use the observer API, but it's not the default, and seems disabled in the provided debug information. And we don't remove the hooks.

derickr commented 8 months ago

Would you like to debug this together?

iamluc commented 8 months ago

Actually I think I found the culprit, and I opened a PR => https://github.com/xdebug/xdebug/pull/947

But sure, I'm available on Room 11 (or other platforms) if you want to discuss this!

derickr commented 8 months ago

I don't know your handle on R11, I'm @Derick (and there now) :-) Because I would like to be able to reproduce it locally first as well (so I can perhaps make a test).

derickr commented 8 months ago

Thanks for debugging and fixing this together! https://github.com/xdebug/xdebug/pull/948 was the final PR.