search

blackfireio / php-sdk

The Blackfire PHP SDK
https://blackfire.io
MIT License
150 stars 22 forks source link

[BUG] BlackfiredHttpClient does not support 'base_uri' specified in underlying HttpClientInterface #74

Closed riki137 closed 5 months ago

riki137 commented 5 months ago

It seems that BlackfiredHttpClient does not account for 'base_uri' being present only in the default options of the underlying client that it's decorating, since it passes static::OPTIONS_DEFAULTS as default options and tries to create URL from that. This makes profiling requests that rely on 'base_uri' in underlying client impossible.

Our base URI is specified in RetryableHttpClient.

image

romainneutron commented 5 months ago

Hello, It should be fixed as of https://github.com/blackfireio/php-sdk/releases/tag/v2.5.2

Thanks for reporting!