blackfireio / php-sdk

The Blackfire PHP SDK
https://blackfire.io
MIT License
150 stars 22 forks source link

Messed up Configuration namespace #8

Closed trylika closed 8 years ago

trylika commented 8 years ago

While initializing BlackFire Client, error is thrown: Argument 1 passed to Blackfire\Client::getRequestDetails() must be an instance of Blackfire\Configuration, instance of Blackfire\Profile\Configuration given, called in /var/www/vendor/blackfire/php-sdk/src/Blackfire/Client.php on line 266 and defined

Problem is that Configuration Namespace changed, but somebody forgot to change definition in here: https://github.com/blackfireio/php-sdk/blob/master/src/Blackfire/Client.php#L299

Applies to BlackFire SDK release 1.4.4

romainneutron commented 8 years ago

Fixed by https://github.com/blackfireio/php-sdk/commit/f05446f844669938e752f648e500e49916a06fc0