search

blackfireio / php-sdk

The Blackfire PHP SDK
https://blackfire.io
MIT License
150 stars 22 forks source link

Fix the fallback probe to be really compatible with PHP 5.2 #9

Closed stof closed 8 years ago

stof commented 8 years ago

The BlackfireProbe polyfill was designed to be compatible with PHP 5.2, but its entry point destroys this by using __DIR__

romainneutron commented 8 years ago

I've moved this PR to the main repo

nicolas-grekas commented 8 years ago

@romainneutron for info, if you use gh to do the switch, then the commit hash will be preserved, and the PR automatically closed as usual

romainneutron commented 8 years ago

I did it à l'ancienne

tucksaun commented 8 years ago

gh does not handle other repo than Symfony when moving PR from a subtree to the upstream IIRC

stof commented 8 years ago

@nicolas-grekas gh does not yet support other repos than symfony in its move command, as we discovered during the hackday when moving my other PRs (btw, the commit hash is not preserved AFAIK, unless the splitter is aware that the commit was moved and finds the original commit again when splitting, due to the way git works)

fabpot commented 8 years ago

Git makes it work quite nicely. When splitting again the commit merged into the main repo, the commit in the subtree split will get the exact same id as in the PR as the conditions are the same: same data, same author, same content, same parent with the same id.

romainneutron commented 8 years ago

Now landed in repo as of 40a601c06c7cfd401ac62144d6d4f23691008012 :)