search

blackfireio / python-sdk

The Blackfire Python SDK https://blackfire.io
MIT License
7 stars 7 forks source link

Fix constants.python_pgo_flag() #16

Closed jlirochon closed 2 years ago

jlirochon commented 2 years ago

As constants._get_sys_config_params() returns a list (item 0 is for PY_CFLAGS and item 1 is for PY_CFLAGS_NODIST), constants.python_pgo_flag() always returns False. This MR fixes the bug by using " ".join() and it can now detect -fprofile-use.

sumerc commented 2 years ago

Hi Julien,

This repo is marked as read-only. However, it is merged as of https://github.com/blackfireio/python-sdk/commit/a7e238aa21ab7782ee8c4fc1f02b39492ad3ff4a including your commit information.

Thanks :)

jlirochon commented 2 years ago

Hi Sümer,

Is there another repo where I should have posted this PR ?

Thanks :)

sumerc commented 2 years ago

The upstream repo is not open-source for now. We forward the community PRs to it. So, it WAS the correct place, thanks again.