Adds ability to override site packages directory for install-bootstrap - Githubissues

blackfireio / python-sdk

The Blackfire Python SDK https://blackfire.io

MIT License

7 stars 7 forks source link

Adds ability to override site packages directory for install-bootstrap #3

Closed moisesbenzan closed 4 years ago

moisesbenzan commented 4 years ago

What does this MR solves?

Better and more extensible way of handling arguments (manual parsing -> argparse)
Allows for special and edge case configurations where the reported python's site-package-dir is not the desired target for installing the .pth file.

How does this MR solves the problem?

Implements the argparse library to handle argument parsing via the command line when Blackfire is used as a module. I.e. python -m blackfire <arguments>.
Allows for the end user to override the site package directory reported by python's get_python_lib(), which in some cases and configurations ignores or skips the PYTHONUSERBASE environment variable.

Note: Backwards compatibility to existing code is maintained.

marcw commented 4 years ago

Hi Moises,

Thanks for your excellent contribution. Unfortunately we won't merge it upstream as we are removing the bootstrap script in the next release (out soon). The benefit: You won't need to install a bootstrap script to use blackfire.

Thanks again, Marc