Omen of Clarity proc rate and Procs per minute are wrong

[Freedye]

SMALL DESCRIPTION:

The proc for Omen of Clarity is wrong, the proc rate is really low compared to how it should be.

EXPECTED BLIZZLIKE BEHAVIOUR:

The proc rate for Omen of Clarity should be 6%, without any ppm rate limitations and without cooldowns. OoC should be triggered by Mark of the wild, and other spells too (except shapeshifting), even when switching specs. https://wowwiki.fandom.com/wiki/Omen_of_Clarity

CURRENT BEHAVIOUR:

The proc rate is now at 0, with a 3.5 ppm rate. Resto druids, balance druids and feral druid are penalised by this bug. I've never saw it's proc from MotW, Thorns etc

STEPS TO REPRODUCE THE PROBLEM:

Tried it on the dummy for 3 min for about 3 hours, got like 7 to 9 procs.

AC HASH/COMMIT:

https://github.com/azerothcore/azerothcore-wotlk/commit/f1b44029c85b9e25318ba84a099b4103e0d98f4e

[Yehonal]

Could be related https://github.com/azerothcore/azerothcore-wotlk/issues/2133

[Freedye]

Could be related azerothcore/azerothcore-wotlk#2133

Yeah it is, but it's much bigger than just swipe. Every druid actions (melee damage, spells and buffs) can trigger it.

This fix is not correct or enough, changing the values on the table "spell_proc_event" is the correct fix, something like:

UPDATEspell_proc_eventSETprocEx=0x0010000,ppmRate=0,CustomChance=6, WHERE entry=16864;`

I suggest to set the procEx since it can also proc from instant spells

[Yehonal]

@Freedye are you available to arrange an in-game test on my local server to test it together? I can easily fix it but we can speedup the testing process

[Yehonal]

good report anyway ;) keep going

[Freedye]

@Freedye are you available to arrange an in-game test on my local server to test it together? I can easily fix it but we can speedup the testing process

I'm on discord right now if you want