search

blackhole89 / notekit

A GTK3 hierarchical markdown notetaking application with tablet support.
GNU General Public License v3.0
1.44k stars 61 forks source link

Fix macos build #121

Closed PikachuHy closed 2 years ago

PikachuHy commented 2 years ago

see https://github.com/blackhole89/notekit/issues/120

sp1ritCS commented 2 years ago

Thanks, we were stuck on this one and didn't know how to fix it. Also see #116

sp1ritCS commented 2 years ago

In ragrds to the failing mingw build, for some reason mirrorbrain picks a mirror that doesn't provide repos in the home: namespace. Maybe it's tagged incorrectly, I'll ask the oS heros later.

PikachuHy commented 2 years ago

maybe we can add a guard 😭 like this

#if defined(__linux__) || defined(_WIN32)
// do nothing
#else
#include <clocale>
#endif
sp1ritCS commented 2 years ago

no, why would we? it seems to work on linux at least. The buils failures aren't due to your commit. (or doesn't it work on windows?)

PikachuHy commented 2 years ago

In ragrds to the failing mingw build

sorry, I misunderstood what you said.

PikachuHy commented 2 years ago

can this PR be merged?

sp1ritCS commented 2 years ago

I've asked about it, since I want this merged too. Development is quite slow, unless something affects @blackhole89 himself :)

Screenshot from 2022-04-02 18-51-25

blackhole89 commented 2 years ago

Argh, sorry! I'm merging it for now, but both the MinGW and the Darwin CI build seem to fail with something pertaining to clatexmath.

PikachuHy commented 2 years ago

both the MinGW and the Darwin CI build seem to fail with something pertaining to clatexmath.

use openmath branch

sp1ritCS commented 2 years ago

@PikachuHy

use openmath branch

no, that wasn't the issue. Darwin CI was failing with linuxbrew and incorrect libstdc++, #124 fixes that.

newer OS X versions seem to fail with cLaTeXMath however (according to one iMac NoteKit user in the chatroom), so I have set up sp1ritCS/tap/notekit-sp1rit and sp1ritCS/tap/microtex that use MicroTeX/openmath. However (likely due to homebrew wierdness) notekit-sp1rit seems to fail to install the datadir and charter fonts property (maybe only when installing the bottle), but I haven't looked further into that.